Add search tabs functionality and grid layout #429
Conversation
|
Unfortunately, this seems to conflict on TabsList.qml. I've made what I think is the proper fix for this here: https://github.com/UniversalSuperBox/morph-browser/tree/xenial_-_tabsearch... Could you check out the edited commits and edit your branch accordingly? |
|
Oooooh! I like! |
There was a problem hiding this comment.
Wow. What a treat to use.
But there are some concerns I have...
Sometimes when I open the tab listing, no tabs are displayed. This is easiest to reproduce when opening the browser with only one tab open. When this occurs, the following is logged:
file:///usr/share/morph-browser/webbrowser/TabsList.qml:256:21: Unable to assign QUrl to QQuickIcon
Ignoring sourceSize request for image url that came from grabToImage. Use the targetSize parameter of the grabToImage() function instead.
Ignoring sourceSize request for image url that came from grabToImage. Use the targetSize parameter of the grabToImage() function instead.
It appears that the search only occurs when the Enter key is pressed. For whatever reason, I expected it to be continuous. Can the search be continuous (as the user types) without adding a lot of complexity or slowing down the model? If not, could the tab list be grayed out while typing so the user doesn't expect it to update until they press Enter? Tapping on the grayed out list should cancel the search and return to it.
|
I haven't encountered this but I'll check UPDATE: I immediately encountered it with 50+ tabs 😅 |
|
What does this mean? What issues still remain? |
|
I can't remember anymore if there were still issues 😅 |
| // WORKAROUND: Repeater items in listNarrowComponent stay hidden when switching from wide to narrow layout | ||
| // if the model is direcly assigned in its definition. This solves that issue. | ||
| target: browser | ||
| onWideChanged: if (!target.wide) searchText = " " |
There was a problem hiding this comment.
Is setting the search text to " " different than setting it to ""?
There was a problem hiding this comment.
yes, "" won't fix the issue 😅
It's not a good workaround, I admit but that's what I came up after hours of debugging :)
Maybe I can go back in the future and see if I can find an actual fix.
This adds a search functionality for tabs.
It can be access with
Ctrl+Space, search button in the tab bar or swiping down from the tabs list in mobile layout.Incidentally, this also fixed #411